--forcemem was being applied twice, the second time in bytes#821
Merged
jmrenouard merged 1 commit intomajor:masterfrom Apr 1, 2025
Merged
--forcemem was being applied twice, the second time in bytes#821jmrenouard merged 1 commit intomajor:masterfrom
jmrenouard merged 1 commit intomajor:masterfrom
Conversation
Collaborator
|
Thanks @nicjansma :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--forcememis already applied in https://github.com/major/MySQLTuner-perl/blob/master/mysqltuner.pl#L536-L545, converting MB to bytes.This second time was overwriting the first, setting it incorrectly in bytes.